[12_3_X] Update the AlCaRecoMatrix for Run 3 #37671

francescobrivio · 2022-04-25T16:56:21Z

PR description:

Backport of #37590
This PR updates the AlCaRecoMatrix to be used for Run 3:

Moved the AlCaRecoMatrix[2018|2017|2016|2015] to AlCa/doc/pastAlCaRecoMatrix.py since they are not really used anywhere in CMSSW, but only kept for documentation purposes
Updated the AlCaRecoMatrix to the values for Run 3, as described in the AlCaRecoMatrix twiki for 2022

PR validation:

Tested with:
runTheMatrix.py -l limited -j 16 --ibeos -t 4

Backport:

Backport of #37590

francescobrivio · 2022-04-25T16:56:37Z

backport of #37590

cmsbuild · 2022-04-25T16:56:58Z

A new Pull Request was created by @francescobrivio for CMSSW_12_3_X.

It involves the following packages:

Configuration/AlCa (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Backported from Update the AlCaRecoMatrix for Run 3 #37590

tvami · 2022-04-25T17:07:05Z

@cmsbuild , please test

cmsbuild · 2022-04-25T20:25:49Z

Pull request #37671 was updated. @cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

tvami · 2022-04-25T20:59:03Z

@cmsbuild , please test

cmsbuild · 2022-04-26T00:26:41Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f63eae/24200/summary.html
COMMIT: 262cddd
CMSSW: CMSSW_12_3_X_2022-04-25-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37671/24200/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 36 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3697135
DQMHistoTests: Total failures: 19
DQMHistoTests: Total nulls: 2
DQMHistoTests: Total successes: 3697092
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.113 KiB( 48 files compared)
DQMHistoSizes: changed ( 1000.0 ): -0.059 KiB MessageLogger/Errors
DQMHistoSizes: changed ( 1000.0 ): -0.059 KiB MessageLogger/Warnings
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

tvami · 2022-04-26T00:41:10Z

+alca

cmsbuild · 2022-04-26T00:41:32Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2022-04-26T18:18:48Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f63eae/24229/summary.html
COMMIT: 262cddd
CMSSW: CMSSW_12_3_X_2022-04-26-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37671/24229/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 26 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3697135
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3697110
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.117 KiB( 48 files compared)
DQMHistoSizes: changed ( 1000.0 ): -0.059 KiB MessageLogger/Errors
DQMHistoSizes: changed ( 1000.0 ): -0.059 KiB MessageLogger/Warnings
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

tvami · 2022-04-26T18:26:04Z

cmsbuild commented 5 minutes ago
+1

oh this is surprising

tvami · 2022-04-26T18:28:26Z

test parameters:

enable_test = threading
workflow_threading = 1001.2

makortel · 2022-04-26T18:29:37Z

I don't see 1001.2 being run in the tests #37671 (comment)
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f63eae/24229/runTheMatrix-results/

tvami · 2022-04-26T18:33:52Z

Hi Matti, yes, you are right, so it seems #37671 (comment) didnt take effect?

tvami · 2022-04-26T18:34:19Z

@cmsbuild , please test workflow 1001.2

makortel · 2022-04-26T18:39:40Z

Hi Matti, yes, you are right, so it seems #37671 (comment) didnt take effect?

The comment had thumbs up so I would have expected the bot to run it. I have no idea what happened.

cmsbuild · 2022-04-26T19:44:19Z

-1

Failed Tests: RelVals RelVals-THREADING
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f63eae/24246/summary.html
COMMIT: 262cddd
CMSSW: CMSSW_12_3_X_2022-04-26-1100/slc7_amd64_gcc10
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37671/24246/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

1001.2

----- Begin Fatal Exception 26-Apr-2022 19:33:34 UTC-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 305064 lumi: 2 event: 1783800 stream: 0
   [1] Running path 'pathALCARECOAlCaPCCRandom'
   [2] Calling method for module AlcaPCCIntegrator/'alcaPCCIntegratorRandom'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: reco::PixelClusterCountsInEvent
Looking for module label: hltAlcaPixelClusterCounts
Looking for productInstanceName: alcaPCCEvent

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

RelVals-THREADING

1001.21001.2_RunZeroBias2017F+RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL+ALCAHARVDSIPIXELCALLA/step2_RunZeroBias2017F+RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL+ALCAHARVDSIPIXELCALLA.log

tvami · 2022-04-28T01:53:34Z

@cmsbuild , please test with #37720

cmsbuild · 2022-04-28T06:39:23Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f63eae/24290/summary.html
COMMIT: 262cddd
CMSSW: CMSSW_12_3_X_2022-04-27-2300/slc7_amd64_gcc10
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37671/24290/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 30 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3697135
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3697104
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.117 KiB( 48 files compared)
DQMHistoSizes: changed ( 1000.0 ): -0.059 KiB MessageLogger/Errors
DQMHistoSizes: changed ( 1000.0 ): -0.059 KiB MessageLogger/Warnings
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

perrotta · 2022-04-28T08:41:10Z

+1

Update the AlCaRecoMatrix for Run 3

2571615

cmsbuild added this to the CMSSW_12_3_X milestone Apr 25, 2022

cmsbuild added alca-pending backport orp-pending pending-signatures tests-pending labels Apr 25, 2022

cmsbuild added tests-started and removed tests-pending labels Apr 25, 2022

add back TkAlMinBias producer to JetHT

262cddd

cmsbuild added tests-pending and removed tests-started labels Apr 25, 2022

cmsbuild added tests-started and removed tests-pending labels Apr 25, 2022

cmsbuild added tests-approved and removed tests-started labels Apr 26, 2022

cmsbuild added alca-approved fully-signed backport-ok and removed alca-pending pending-signatures backport labels Apr 26, 2022

cmsbuild added the tests-started label Apr 26, 2022

cmsbuild added tests-approved and removed tests-started labels Apr 26, 2022

tvami mentioned this pull request Apr 26, 2022

ProductNotFound exception in AlcaPCCIntegrator in workflow 1001.2 #37685

Closed

cmsbuild added tests-started and removed tests-approved labels Apr 26, 2022

cmsbuild added tests-rejected and removed tests-started labels Apr 26, 2022

qliphy mentioned this pull request Apr 28, 2022

do not fetch PixelClusterCountsInEvent when the handle is not valid #37712

Merged

cmsbuild added requires-external tests-started and removed tests-rejected labels Apr 28, 2022

cmsbuild added tests-approved and removed tests-started labels Apr 28, 2022

perrotta mentioned this pull request Apr 28, 2022

[12_3_X] Do not fetch PixelClusterCountsInEvent when the handle is not valid #37720

Merged

cmsbuild added orp-approved and removed orp-pending labels Apr 28, 2022

cmsbuild merged commit 866ffe0 into cms-sw:CMSSW_12_3_X Apr 28, 2022

francescobrivio deleted the alca-improveAutoAlCa_12_3_X branch May 1, 2022 16:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12_3_X] Update the AlCaRecoMatrix for Run 3 #37671

[12_3_X] Update the AlCaRecoMatrix for Run 3 #37671

francescobrivio commented Apr 25, 2022

francescobrivio commented Apr 25, 2022

cmsbuild commented Apr 25, 2022 •

edited

Loading

tvami commented Apr 25, 2022

cmsbuild commented Apr 25, 2022

tvami commented Apr 25, 2022

cmsbuild commented Apr 26, 2022

tvami commented Apr 26, 2022

cmsbuild commented Apr 26, 2022

cmsbuild commented Apr 26, 2022

tvami commented Apr 26, 2022

tvami commented Apr 26, 2022 •

edited

Loading

makortel commented Apr 26, 2022

tvami commented Apr 26, 2022

tvami commented Apr 26, 2022

makortel commented Apr 26, 2022

cmsbuild commented Apr 26, 2022

tvami commented Apr 28, 2022

cmsbuild commented Apr 28, 2022

perrotta commented Apr 28, 2022

[12_3_X] Update the AlCaRecoMatrix for Run 3 #37671

[12_3_X] Update the AlCaRecoMatrix for Run 3 #37671

Conversation

francescobrivio commented Apr 25, 2022

PR description:

PR validation:

Backport:

francescobrivio commented Apr 25, 2022

cmsbuild commented Apr 25, 2022 • edited Loading

tvami commented Apr 25, 2022

cmsbuild commented Apr 25, 2022

tvami commented Apr 25, 2022

cmsbuild commented Apr 26, 2022

Comparison Summary

tvami commented Apr 26, 2022

cmsbuild commented Apr 26, 2022

cmsbuild commented Apr 26, 2022

Comparison Summary

tvami commented Apr 26, 2022

tvami commented Apr 26, 2022 • edited Loading

makortel commented Apr 26, 2022

tvami commented Apr 26, 2022

tvami commented Apr 26, 2022

makortel commented Apr 26, 2022

cmsbuild commented Apr 26, 2022

RelVals

RelVals-THREADING

tvami commented Apr 28, 2022

cmsbuild commented Apr 28, 2022

Comparison Summary

perrotta commented Apr 28, 2022

cmsbuild commented Apr 25, 2022 •

edited

Loading

tvami commented Apr 26, 2022 •

edited

Loading